[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

This revision was automatically updated to reflect the committed changes. Closed by commit rL355629: [lldb] Fix DW_OP_addrx uses. (authored by tamur, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D59004?v

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

labath added a comment. Thank you. The test looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59004/new/ https://reviews.llvm.org/D59004 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

tamur updated this revision to Diff 189652. tamur added a comment. Herald added a subscriber: jdoerfert. Discarded changes to the unit test and added a lit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59004/new/ https://reviews.llvm.org/D590

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

labath added a comment. Would a test similar to `lit/SymbolFile/DWARF/array-sizes.s` be possible/appropriate? I'm thinking of something like: - produce debug info in the form of a .s file (either with clang of via hand-tuning dwarf) which uses DW_OP_addrx - assemble&link it - run lldb, have it

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

tamur updated this revision to Diff 189423. tamur added a comment. Herald added a reviewer: serge-sans-paille. Added a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59004/new/ https://reviews.llvm.org/D59004 Files: lldb/packages/Python/lld

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

aprantl added a comment. Is there a way to force clang to generate this and/or are existing tests failing because this support is missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59004/new/ https://reviews.llvm.org/D59004

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

aprantl added a comment. The code looks fine, but this needs a testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59004/new/ https://reviews.llvm.org/D59004 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

tamur updated this revision to Diff 189415. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59004/new/ https://reviews.llvm.org/D59004 Files: lldb/source/Expression/DWARFExpression.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

tamur marked an inline comment as done. tamur added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:2910 //-- // OPCODE: DW_OP_GNU_addr_index // OPERANDS: 1

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

shafik added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:2910 //-- // OPCODE: DW_OP_GNU_addr_index // OPERANDS: 1 Should this comment be updated? Repo

[Lldb-commits] [PATCH] D59004: [lldb] Fix DW_OP_addrx uses.

tamur created this revision. tamur added a project: LLDB. Herald added a subscriber: lldb-commits. DW_OP_GNU_addr_index has been renamed as DW_OP_addrx in the standard. clang produces DW_OP_addrx tags and with this change lldb starts to process them. Repository: rLLDB LLDB https://reviews.ll