[Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

labath abandoned this revision. labath added a comment. instead of a fresh tool, minidump support will be added to obj2yaml. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58976/new/ https://reviews.llvm.org/D58976 ___ lldb-commits mailing l

Re: [Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

Does objdump not read core files? Jim > On Mar 5, 2019, at 8:53 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > In D58976#1418596 , @clayborg wrote: > >> Do we want this in LLVM instead of lldb? > > > The

[Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

zturner added a comment. In D58976#1418621 , @clayborg wrote: > Strong ownership is needed for this class IMHO because it hands out pointers > to native data I disagree here, see my previous comment. Binaries grow large very quickly, and if we always

[Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

clayborg added a comment. Strong ownership is needed for this class IMHO because it hands out pointers to native data CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58976/new/ https://reviews.llvm.org/D58976 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

clayborg added inline comments. Comment at: include/lldb/Formats/MinidumpParser.h:105 private: - lldb::DataBufferSP m_data_sp; + llvm::ArrayRef m_data; + const MinidumpHeader *m_header; I worry about this going stale when the owner of the data lets it go and

[Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

labath added a comment. In D58976#1418596 , @clayborg wrote: > Do we want this in LLVM instead of lldb? The thought has crossed my mind, but for that I would have to also move the minidump parser into llvm. It's already pretty standalone, so it shouldn'

[Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

clayborg added a comment. Do we want this in LLVM instead of lldb? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58976/new/ https://reviews.llvm.org/D58976 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

labath created this revision. labath added reviewers: zturner, lemo, clayborg, JDevlieghere. Herald added a subscriber: mgorny. This patch introduces the core2yaml tool, whose purpose is to dump core files in a human readable (and, ideally, editable) format. It's very similar to llvm's obj2yaml, e