[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

labath added a comment. In D58792#1415631 , @clayborg wrote: > If this is new API I guess it is ok to have them all be const. I was mostly > worried that you wouldn't be able to call a non const function from a const > function. Do we have any IsValid()

[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

labath updated this revision to Diff 189057. labath added a comment. The version which makes "operator bool" const. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58792/new/ https://reviews.llvm.org/D58792 Files: include/lldb/API/SBAddress.h include/lldb/API/SBBlock.h include/lldb

[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

jingham added a comment. In D58792#1415645 , @clayborg wrote: > In D58792#1415629 , @zturner wrote: > > > Out of curiosity, are there known, specific examples of users who rely on > > the exact mangling not changin

[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

clayborg added a comment. In D58792#1415629 , @zturner wrote: > Out of curiosity, are there known, specific examples of users who rely on the > exact mangling not changing? yes. Xcode. For Swift, Xcode runs the LLDBRPC.framework in process which runs l

[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

jingham added a comment. In D58792#1415629 , @zturner wrote: > Out of curiosity, are there known, specific examples of users who rely on the > exact mangling not changing? Yes, both Xcode and lldb-rpc-server (an out-of-process dingus we made for Xcod

[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

clayborg added a comment. If this is new API I guess it is ok to have them all be const. I was mostly worried that you wouldn't be able to call a non const function from a const function. Do we have any IsValid() calls that are const? I believe we do. If so, how are we calling IsValid() if it i

[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

zturner added a comment. Out of curiosity, are there known, specific examples of users who rely on the exact mangling not changing? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58792/new/ https://reviews.llvm.org/D58792 ___ lldb-commits m

[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

shafik added a comment. In D58792#1415390 , @clayborg wrote: > In D58792#1414964 , @labath wrote: > > > In D58792#1414191 , @shafik wrote: > > > > > It stood out to me that s

[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

labath updated this revision to Diff 188966. labath added a comment. Give up on constness and make all bool operators non-const. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58792/new/ https://reviews.llvm.org/D58792 Files: include/lldb/API/SBAddress.h include/lldb/API/SBBlock.h

[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

clayborg added a comment. In D58792#1414964 , @labath wrote: > In D58792#1414191 , @shafik wrote: > > > It stood out to me that some of the conversions were not `const` and I can > > see that `IsValid` is not consi

[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

labath added a comment. In D58792#1414191 , @shafik wrote: > It stood out to me that some of the conversions were not `const` and I can > see that `IsValid` is not consistently `const` across the API but after > talking to @jingham it is unfortunately so

[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

shafik added a comment. It stood out to me that some of the conversions were not `const` and I can see that `IsValid` is not consistently `const` across the API but after talking to @jingham it is unfortunately something we can't change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58

[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

labath created this revision. labath added reviewers: zturner, jingham, clayborg. Herald added a reviewer: jfb. Herald added a reviewer: serge-sans-paille. Herald added a subscriber: jdoerfert. Our python version of the SB API has (the python equivalent of) operator bool, but the C++ version doesn