[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

JDevlieghere resigned from this revision. JDevlieghere added a comment. I believe this isn't relevant anymore after moving Symbols? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58654/new/ https://reviews.llvm.org/D58654 ___ lldb-commits ma

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

zturner added a comment. In D58654#1411084 , @labath wrote: > BTW, what's the reason that you have to have this split now? I understand its > attractiveness from a Zen perspective, but it seems to me that at the end of > the day, it doesn't have that muc

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

JDevlieghere added a comment. In D58654#1410852 , @zturner wrote: > In D58654#1410817 , @JDevlieghere > wrote: > > > I'm not a fan of introducing another library for this. Without a clear > > timeline of "fixing"

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

labath added a comment. BTW, what's the reason that you have to have this split now? I understand its attractiveness from a Zen perspective, but it seems to me that at the end of the day, it doesn't have that much impact on the new code you're about to write. It seems to me you could still enfo

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

zturner added a comment. In D58654#1410817 , @JDevlieghere wrote: > I'm not a fan of introducing another library for this. Without a clear > timeline of "fixing" Host it's basically as temporary as anything else in > software development. I also think i

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

JDevlieghere added a comment. I'm not a fan of introducing another library for this. Without a clear timeline of "fixing" Host it's basically as temporary as anything else in software development. I also think it's confusing (e,g, new files should go where?). If you really want a clean slate we

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

zturner updated this revision to Diff 188393. zturner added a comment. Moved to `System` instead of `Utility` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58654/new/ https://reviews.llvm.org/D58654 Files: lldb/cmake/XcodeHeaderGenerator/CMakeLists.txt lldb/cmake/modules/LLDBGenera

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

labath added a comment. I also think it would be great to group all host-specific functionality into a common library (other than Utility, since that already has a lot of other stuff in it). I understand the desire to start with a clean slate for a new tool, so a new would-be-host folder might

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

zturner added a comment. In D58654#1410080 , @jingham wrote: > There aren't many more platforms (OpenVMS?) that are likely to show up and > need support for lldb, so maybe this is making too much of the matter. But > having there be a well defined set o

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

jingham added a comment. There aren't many more platforms (OpenVMS?) that are likely to show up and need support for lldb, so maybe this is making too much of the matter. But having there be a well defined set of places where you need to look when porting lldb to a new host platform seems a us

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

zturner added a comment. In D58654#1409974 , @jingham wrote: > Utility is supposed to be a bunch of stand-alone utility files & headers that > we gather together for convenience's sake. > > Host is where we put all the code that is specific to one or anot

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

jingham added a comment. Utility is supposed to be a bunch of stand-alone utility files & headers that we gather together for convenience's sake. Host is where we put all the code that is specific to one or another host, and any support files that requires. For instance, that's why PlatformLin

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

JDevlieghere added a comment. Makes sense, no objections from me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58654/new/ https://reviews.llvm.org/D58654 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [PATCH] D58654: Move Config.h from Host to Utility

zturner created this revision. zturner added reviewers: labath, jgorbe, JDevlieghere, davide. Herald added subscribers: mgorny, emaste. `Host/Config.h` is where we have platform specific preprocessor defines that are configured at CMake time. Then, we can include this file `lldb/Host/Config.h`