This revision was automatically updated to reflect the committed changes.
Closed by commit rL354202: Fix TestDataFormatterLibcxxListLoop.py test
(authored by teemperor, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://review
shafik added a comment.
Thanks for fixing this.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58273/new/
https://reviews.llvm.org/D58273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
teemperor updated this revision to Diff 186994.
teemperor edited the summary of this revision.
teemperor added a comment.
- Added #ifdef for 3.8 release.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58273/new/
https://reviews.llvm.org/D58273
Files:
lldb/packages/Python/lldbsuite/te
labath added a comment.
Yeah, that sounds like a good interim solution.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58273/new/
https://reviews.llvm.org/D58273
___
lldb-commits mailing list
lldb-commits@lists.llvm
teemperor added a comment.
We could also check the libc++ version via _LIBCPP_VERSION and just keep the
old code around behind an ifdef?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58273/new/
https://reviews.llvm.org/D58273
___
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
The slight problem here is that we don't know which libc++ version we are going
to build with, so this will then fail for people still using the old one.
However, choosing the latest libc++ ve
teemperor created this revision.
teemperor added reviewers: shafik, zturner, labath.
Herald added subscribers: lldb-commits, jdoerfert, christof.
Herald added a project: LLDB.
The compilation of the TestDataFormatterLibcxxListLoop.py currently fails with
this error:
functionalities/data-forma
