Eugene.Zelenko added inline comments.
Comment at: lldb/source/Plugins/Process/minidump/ProcessMinidump.cpp:10
#include "ProcessMinidump.h"
+
#include "ThreadMinidump.h"
Spurious separator.
Comment at: lldb/source/Plugins/Process/minidump/Thre
tatyana-krasnukha added a comment.
Yes, of course!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57990/new/
https://reviews.llvm.org/D57990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
JDevlieghere added a comment.
@tatyana-krasnukha and @Eugene.Zelenko, are you okay with me addressing those
thing in a follow-up?
Comment at: lldb/source/API/SBData.cpp:12
+#include
+
#include "lldb/API/SBData.h"
Eugene.Zelenko wrote:
> JDevlieghere wrote:
>
Eugene.Zelenko added inline comments.
Comment at: lldb/source/API/SBTypeEnumMember.cpp:78
TypeEnumMemberImpl &SBTypeEnumMember::ref() {
if (m_opaque_sp.get() == NULL)
+m_opaque_sp = std::make_shared();
tatyana-krasnukha wrote:
> ```
> if (!m_opaque_sp)
>
tatyana-krasnukha added a comment.
These also don't relate directly but intersect with your changes:
Comment at: lldb/source/API/SBTypeEnumMember.cpp:78
TypeEnumMemberImpl &SBTypeEnumMember::ref() {
if (m_opaque_sp.get() == NULL)
+m_opaque_sp = std::make_shared();
-
tatyana-krasnukha added a comment.
A few modernizations which though don't directly relate to make_shared:
Comment at: lldb/source/API/SBCommandInterpreter.cpp:560
lldb::CommandObjectSP new_command_sp;
- new_command_sp.reset(new CommandPluginInterfaceImplementation(
-
labath added a comment.
I agree with Eugene that the empty lines interfere with clang-format and that
llvm does not use empty lines between system and own headers. However, our
headers are already very inconsistent with that, so I don't think fixing that
should be a part of this patch. It would
jfb added a comment.
Do you ever use weak pointers? The single allocation is good until you start
holding on to more things (because you can't just keep the block around, you
need the entire allocation), so you should make sure you won’t be delaying
memory being reclaimed.
Repository:
rLLDB
Eugene.Zelenko added inline comments.
Comment at: lldb/source/API/SBData.cpp:12
+#include
+
#include "lldb/API/SBData.h"
JDevlieghere wrote:
> Eugene.Zelenko wrote:
> > JDevlieghere wrote:
> > > jingham wrote:
> > > > Eugene.Zelenko wrote:
> > > > > Spaces betw
JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.
Comment at: lldb/source/API/SBData.cpp:12
+#include
+
#include "lldb/API/SBData.h"
Eugene.Zelenko wrote:
> JDevlieghere wrote:
> > jingham wrote:
> > > Eugene.Zelenko wrote:
> >
Eugene.Zelenko added inline comments.
Comment at: lldb/source/API/SBData.cpp:12
+#include
+
#include "lldb/API/SBData.h"
JDevlieghere wrote:
> jingham wrote:
> > Eugene.Zelenko wrote:
> > > Spaces between include statements interfere with Clang-format. Same in
JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.
Comment at: lldb/source/API/SBData.cpp:12
+#include
+
#include "lldb/API/SBData.h"
jingham wrote:
> Eugene.Zelenko wrote:
> > Spaces between include statements interfere with Cla
jingham added inline comments.
Comment at: lldb/source/API/SBData.cpp:12
+#include
+
#include "lldb/API/SBData.h"
Eugene.Zelenko wrote:
> Spaces between include statements interfere with Clang-format. Same in other
> places.
How?
We always separate system hea
Eugene.Zelenko added inline comments.
Comment at: lldb/source/API/SBData.cpp:9
#include
cinttypes should be used instead. See Clang-tidy modernize-deprecated-headers.
Same in other places.
Comment at: lldb/source/API/SBData.cpp:12
+#incl
14 matches
Mail list logo
