[Lldb-commits] [PATCH] D57840: Convert TestCommandRegex to lit (from expect)

2019-02-06 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM, thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57840/new/ https://reviews.llvm.org/D57840 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D57840: Convert TestCommandRegex to lit (from expect)

2019-02-06 Thread Davide Italiano via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL353345: [testsuite] Convert a pexpect test to lit. (authored by davide, committed by ). Changed prior to commit: https://reviews.llvm.org/D57840?vs=185634&id=185635#toc Repository: rL LLVM CHANGES S

[Lldb-commits] [PATCH] D57840: Convert TestCommandRegex to lit (from expect)

2019-02-06 Thread Davide Italiano via Phabricator via lldb-commits
davide updated this revision to Diff 185634. davide added a comment. jonas was right Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57840/new/ https://reviews.llvm.org/D57840 Files: lldb/lit/Commands/command-regex-delete.test lldb/lit/Commands/command-regex-un

[Lldb-commits] [PATCH] D57840: Convert TestCommandRegex to lit (from expect)

2019-02-06 Thread Davide Italiano via Phabricator via lldb-commits
davide updated this revision to Diff 185633. davide added a comment. zturner's update. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57840/new/ https://reviews.llvm.org/D57840 Files: lldb/packages/Python/lldbsuite/test/functionalities/command_regex/.categories

[Lldb-commits] [PATCH] D57840: Convert TestCommandRegex to lit (from expect)

2019-02-06 Thread Zachary Turner via Phabricator via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Can you rename these two tests to `command-regex-delete.test` and `command-regex-unalias.test`? Otherwise, lgtm Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/