[Lldb-commits] [PATCH] D57780: Don't include UnixSignals.h from Host

2019-02-15 Thread Zachary Turner via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB354168: Don't include UnixSignals.h from Host. (authored by zturner, committed by ). Herald added subscribers: abidh, arichardson, emaste. Herald added a reviewer: espindola. Herald added a project: LLD

[Lldb-commits] [PATCH] D57780: Don't include UnixSignals.h from Host

2019-02-06 Thread Pavel Labath via Phabricator via lldb-commits
labath added reviewers: jingham, davide. labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. The rationale you give for this class being in Target is sound from the POV of lldb client. (the CreateForHost function is slightly fishy, but not too m

[Lldb-commits] [PATCH] D57780: Don't include UnixSignals.h from Host

2019-02-05 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. zturner added a reviewer: labath. Herald added a reviewer: jfb. This file lives in Target, which makes sense since it is supposed to represent the various types of signals that can occur on any platform (since you might be remote debugging a platform with different