[Lldb-commits] [PATCH] D57467: Fix use of non-existing variable in crashlog.py

2019-01-31 Thread Shafik Yaghmour via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB352772: Fix use of non-existing variable in crashlog.py (authored by shafik, committed by ). Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57467/new/ https://reviews.

[Lldb-commits] [PATCH] D57467: Fix use of non-existing variable in crashlog.py

2019-01-30 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. Thanks!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57467/new/ https://reviews.llvm.org/D57467 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit

[Lldb-commits] [PATCH] D57467: Fix use of non-existing variable in crashlog.py

2019-01-30 Thread Davide Italiano via Phabricator via lldb-commits
davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57467/new/ https://reviews.llvm.org/D57467 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D57467: Fix use of non-existing variable in crashlog.py

2019-01-30 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik created this revision. shafik added reviewers: aprantl, jingham. Herald added a reviewer: serge-sans-paille. The method find_matching_slice(self) uses `uuid_str` on one of the paths but the variable does not exist and so this results in a NameError exception if we take that path. https: