JDevlieghere updated this revision to Diff 183877.
JDevlieghere added a comment.
- Remove trailing characters from get_command_status_output.
- Remove unused seven imports.
(I'll land this as two separate commits)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57275/new/
https://reviews
labath added a comment.
+1 for keeping seven.py. Anything that moves code out of dotest.py is a good
thing.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57275/new/
https://reviews.llvm.org/D57275
___
lldb-commits
Huh, that’s a coincidence. I chose the name because it was “like six”, but
I guess someone else chose it for the same reason
On Sat, Jan 26, 2019 at 2:18 PM Jonas Devlieghere
wrote:
>
>
> On Fri, Jan 25, 2019 at 8:44 PM Zachary Turner via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
>
>>
On Fri, Jan 25, 2019 at 8:44 PM Zachary Turner via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> The idea behind seven is that it’s a place to put stuff that we need for
> py2/py3 interoperability that doesn’t already exist in six. Yes, maybe
> there’s only one thing there now, but there co
stella.stamenova added a comment.
I don't have a strong preference between using a separate module for
interopability between python versions and implementing the functions as part
of dotest if there are few of them, but I have to agree with @zturner that if
we have more than a couple of functi
The idea behind seven is that it’s a place to put stuff that we need for
py2/py3 interoperability that doesn’t already exist in six. Yes, maybe
there’s only one thing there now, but there could be more over time.
At least that was the thinking when I created it.
It seems like there’s two separate
JDevlieghere created this revision.
JDevlieghere added reviewers: davide, zturner, stella.stamenova, labath.
JDevlieghere added a project: LLDB.
Herald added a reviewer: serge-sans-paille.
When running the test suite on macOS with Python 3 we noticed a difference in
behavior between Python 2 and
