Re: [Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

On Wed, Jan 30, 2019 at 10:53 AM Zachary Turner wrote: > > Oh I guess because one of them has const values? Oh well, ignore my > suggestion then :) > I think so. Too bad, it would've been a nice cleanup :) -- Davide ___ lldb-commits mailing list lldb

Re: [Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

Oh I guess because one of them has const values? Oh well, ignore my suggestion then :) On Wed, Jan 30, 2019 at 10:50 AM Davide Italiano via Phabricator < revi...@reviews.llvm.org> wrote: > davide marked an inline comment as done. > davide added inline comments. > > > > Comment a

[Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/source/Utility/Scalar.cpp:168 + swapped_words[6] = apint_words[1]; + swapped_words[7] = apint_words[0]; + apint_words = swapped_words; zturner wrote: > davide w

[Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

zturner added inline comments. Comment at: lldb/source/Utility/Scalar.cpp:168 + swapped_words[6] = apint_words[1]; + swapped_words[7] = apint_words[0]; + apint_words = swapped_words; davide wrote: > davide wrote: > > aprantl wrote: > > > std::rever

[Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/source/Utility/Scalar.cpp:168 + swapped_words[6] = apint_words[1]; + swapped_words[7] = apint_words[0]; + apint_words = swapped_words; davide wrote: > aprantl w

[Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/source/Utility/Scalar.cpp:161 +if (endian::InlHostByteOrder() == eByteOrderBig) { + swapped_words[0] = apint_words[7]; + swapped_words[1] = apint_words[6]; zturn

[Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

zturner added inline comments. Comment at: lldb/source/Utility/Scalar.cpp:161 +if (endian::InlHostByteOrder() == eByteOrderBig) { + swapped_words[0] = apint_words[7]; + swapped_words[1] = apint_words[6]; I'm confused. You say it returns a pointer t

[Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

davide added a comment. Thanks for the review, Greg! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57213/new/ https://reviews.llvm.org/D57213 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

davide marked 2 inline comments as done. davide added inline comments. Comment at: lldb/source/Utility/RegisterValue.cpp:159 case 32: +case 64: if (buffer.length % sizeof(uint64_t) == 0) { aprantl wrote: > I'm curious, everything else in this patc

[Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

aprantl added inline comments. Comment at: lldb/source/Utility/RegisterValue.cpp:159 case 32: +case 64: if (buffer.length % sizeof(uint64_t) == 0) { I'm curious, everything else in this patch refers to 512, how does this fit in?

[Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

davide added a comment. @clayborg, this is fairly mechanical, but I would appreciate if you can sign it off. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57213/new/ https://reviews.llvm.org/D57213 ___ lldb-commits mailing list lldb-commit

[Lldb-commits] [PATCH] D57213: [Scalar] Add support for 512-bits values.

davide created this revision. davide added a reviewer: clayborg. rdar://problem/46886288 https://reviews.llvm.org/D57213 Files: lldb/include/lldb/Utility/Scalar.h lldb/source/Utility/RegisterValue.cpp lldb/source/Utility/Scalar.cpp lldb/unittests/Utility/ScalarTest.cpp Index: lldb/unit