labath marked 7 inline comments as done.
labath added a comment.
Thanks for the review. I'll create another review with the changes stemming
from this.
Comment at: lldb/trunk/source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:74
+ static_assert(sizeof(data) == 20, "");
+
lemo added a comment.
Looks good. A few questions/suggestions inline.
Comment at: lldb/trunk/source/Plugins/ObjectFile/Breakpad/BreakpadRecords.cpp:74
+ static_assert(sizeof(data) == 20, "");
+ // The textual module id encoding should be between 33 and 40 bytes long,
+ // de
This revision was automatically updated to reflect the committed changes.
Closed by commit rL351541: Breakpad: Extract parsing code into a separate file
(authored by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Never mind, just read the update to your other patch. Would be nice to identify
line records in toToken, but that will probably cost more CPU cycles that it is
worth, so I think this is a
clayborg added a comment.
Are we missing parsing of FUNC and line entry lines in this patch?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56844/new/
https://reviews.llvm.org/D56844
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
labath created this revision.
labath added reviewers: clayborg, lemo, zturner.
Herald added subscribers: fedor.sergeev, mgorny.
This centralizes parsing of breakpad records, which was previously
spread out over ObjectFileBreakpad and SymbolFileBreakpad.
For each record type X there is a separate
