[Lldb-commits] [PATCH] D56814: [Reproducers] Refactor reproducer info

2019-01-17 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. JDevlieghere marked 2 inline comments as done. Closed by commit rL351501: [Reproducers] Refactor reproducer info (authored by JDevlieghere, c

[Lldb-commits] [PATCH] D56814: [Reproducers] Refactor reproducer info

2019-01-17 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. This looks much better. LGTM, just make sure to do something with the lower_bound search, as I don't think that's right. Comment at: include/lldb/Utility/Reproducer.h:58-59 + virtual const char *GetName() const = 0; + virtual const char *GetFile() c

[Lldb-commits] [PATCH] D56814: [Reproducers] Refactor reproducer info

2019-01-16 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: labath, davide. Herald added subscribers: abidh, mgrang. In the original reproducer design, I expected providers to be more dynamic than they turned out. For example, we don't have any instances where one provider has multiple fil