This revision was automatically updated to reflect the committed changes.
Closed by commit rL353404: SymbolFileBreakpad: Add line table support (authored
by labath, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.ll
labath updated this revision to Diff 185557.
labath edited the summary of this revision.
labath added a comment.
Add a bounds check to the GetCompileUnitAtIndex method
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56595/new/
https://reviews.llvm.org/D56595
Files:
include/lldb/Core/Fi
clayborg added a comment.
Just bounds check "index" in parse compile unit and this is good to go
Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:196
+
+ CompUnitData &data = m_cu_data->GetEntryRef(index).data;
+
Validate "index" first? We
labath updated this revision to Diff 185533.
labath marked 2 inline comments as done.
labath added a comment.
Tried to make parsing as lazy as possible. GetNumSections() will count the
number of FUNC records, but will not create CompileUnit objects. FILE records
will be parsed when we create the f
lemo accepted this revision.
lemo added a comment.
This revision is now accepted and ready to land.
The latest version looks good to me. Please update the description (it still
says it uses the one CU per symbols file)
Comment at: include/lldb/Core/FileSpecList.h:72
+ /// Mov
labath marked 11 inline comments as done.
labath added a comment.
Thanks for the review Greg. See my responses inline. I'm going to try
incorporating the changes tomorrow.
Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:279
+ llvm::Optional func;
+ for
clayborg added a comment.
I like the way you did the compile units and the line tables and support file
list. It would be nice to change this to do things more lazily. Right now we
are parsing all compile unit data into CompUnitData structures and then passing
their info along to the lldb_priva
labath added a comment.
Greg, what do you think about the new approach in this patch?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56595/new/
https://reviews.llvm.org/D56595
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:/
labath updated this revision to Diff 184103.
labath added a comment.
It took me a while to get back to this, but I believe this version now does what
we want. It creates a compile unit for each function. The compile units are
created as soon as the symbol file is initialized (it's needed to get th
labath planned changes to this revision.
labath added a comment.
I think I understand what you mean. I'll try to refactor this to create a
compile unit for each function.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56595/new/
https://reviews.llvm.org/D56595
___
clayborg added a comment.
So LLDB treats compile units special depending on the inline strategy. Because
of this, I outlined some examples of how and why we should create a compile
unit per "FUNC" token. Let me know if anything above was unclear
Comment at: source/Plugins/Sym
labath marked an inline comment as done.
labath added inline comments.
Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:150-151
+line_table_up->AppendLineEntryToSequence(
+line_seq_up.get(), *next_addr, /*line*/ 0, /*column*/ 0,
+/*file_id
labath created this revision.
labath added reviewers: clayborg, zturner, lemo, markmentovai.
This patch teaches SymbolFileBreakpad to parse the line information in
breakpad files and present it to lldb.
The trickiest question here was what kind of "compile units" to present
to lldb, as there real
13 matches
Mail list logo
