This revision was automatically updated to reflect the committed changes.
Closed by commit rL351781: breakpad: Add FUNC records to the symtab (authored
by labath, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Much cleaner! Thanks
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56590/new/
https://reviews.llvm.org/D56590
___
lldb-commits maili
labath added inline comments.
Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:26
namespace {
class LineIterator {
public:
clayborg wrote:
> Move this functionality into llvm::breakpad::Line?
I haven't moved this part to the new file becau
labath updated this revision to Diff 182254.
labath marked 7 inline comments as done.
labath added a comment.
Thanks for the review. I've refactored the code to separate (and centralize) the
breakpad parsing from the part which does presents the information to lldb.
I've done this slightly differ
clayborg added inline comments.
Comment at: source/Plugins/SymbolFile/Breakpad/SymbolFileBreakpad.cpp:232
+ };
+ for (llvm::StringRef line: lines(*m_obj_file, Token::Func)) {
+// Here we can get either FUNC records (starting with FUNC), or line
records
Sho
clayborg added inline comments.
Comment at: source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp:29-48
+Token breakpad::toToken(llvm::StringRef str) {
return llvm::StringSwitch(str)
.Case("MODULE", Token::Module)
.Case("INFO", Token::Info)
.Case("FILE
labath created this revision.
labath added reviewers: zturner, lemo, clayborg, markmentovai.
Herald added a subscriber: aprantl.
This patch extends SymbolFileBreakpad::AddSymbols to include the symbols
from the FUNC records too. These symbols come from the debug info and
have a size associated wit
