[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

2019-01-11 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz abandoned this revision. sgraenitz added a comment. I will split off the "dead code elimination" part and close both reviews in favor of a more comprehensive fix. Comment at: CMakeLists.txt:49 set(LLDB_DEFAULT_TEST_FILECHECK "${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR

[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

2019-01-10 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova requested changes to this revision. stella.stamenova added inline comments. This revision now requires changes to proceed. Comment at: CMakeLists.txt:49 set(LLDB_DEFAULT_TEST_FILECHECK "${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin/FileCheck${CMAKE_EXECUTABLE_SU

[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

2019-01-08 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz marked 7 inline comments as done. sgraenitz added inline comments. Comment at: CMakeLists.txt:43 if(LLDB_INCLUDE_TESTS) + # FIXME: LLDB_TEST_CXX_COMPILER is unused. + # FIXME: In standalone builds LLVM_BINARY_DIR points to LLDB's build directory and not to LLVM's! -

[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

2019-01-08 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz updated this revision to Diff 180643. sgraenitz added a comment. Act on FIXME's in subsequent commits and remove comments here CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56400/new/ https://reviews.llvm.org/D56400 Files: CMakeLists.txt lit/CMakeLists.txt Index: lit/CM

[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

2019-01-08 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz added inline comments. Comment at: CMakeLists.txt:43 if(LLDB_INCLUDE_TESTS) + # FIXME: LLDB_TEST_CXX_COMPILER is unused. + # FIXME: In standalone builds LLVM_BINARY_DIR points to LLDB's build directory and not to LLVM's! labath wrote: > JDevlieghere

[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

2019-01-08 Thread Pavel Labath via Phabricator via lldb-commits
labath added a reviewer: stella.stamenova. labath added a comment. This looks fine to me. I recommend including Stella in changes relating to this, as I recall some subtleties here wrt. multi-config (e.g., MSVC) generators. Comment at: CMakeLists.txt:43 if(LLDB_INCLUDE_TESTS

[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

2019-01-07 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: CMakeLists.txt:43 if(LLDB_INCLUDE_TESTS) + # FIXME: LLDB_TEST_CXX_COMPILER is unused. + # FIXME: In standalone builds LLVM_BINARY_DIR points to LLDB's build directory and not to LLVM's! Why is this unused? Are w

[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

2019-01-07 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: CMakeLists.txt:44 + # FIXME: LLDB_TEST_CXX_COMPILER is unused. + # FIXME: In standalone builds LLVM_BINARY_DIR points to LLDB's build directory and not to LLVM's! + # FIXME: LLDB_TEST_USE

[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

2019-01-07 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz marked an inline comment as done. sgraenitz added inline comments. Comment at: CMakeLists.txt:47 + # FIXME: With generator expressions we could simply query the output paths for each target, + # but for this LLDB_DOTEST_ARGS must always have a generator step. -

[Lldb-commits] [PATCH] D56400: [CMake] Some cleanup around test preparations

2019-01-07 Thread Stefan Gränitz via Phabricator via lldb-commits
sgraenitz created this revision. sgraenitz added reviewers: aprantl, JDevlieghere, labath, vsk. Herald added a subscriber: mgorny. Fix some issues in the code around D56399 : - remove outdated comments - streamline empty-string conditions - remove 2 uses of LLDB_T