[Lldb-commits] [PATCH] D56208: Add file-based synchronization to flaky test

2019-01-03 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. Herald added a reviewer: serge-sans-paille. I implemented a poor man's version of that in r350360. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56208/new/ https://reviews.llvm.org/D56208 ___

[Lldb-commits] [PATCH] D56208: Add file-based synchronization to flaky test

2019-01-02 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py:132 self.fail("Failed to stop at breakpoint 1.") +self.await_token(exe) Will this actually help? It could be I'm missing someth

[Lldb-commits] [PATCH] D56208: Add file-based synchronization to flaky test

2019-01-02 Thread Phabricator via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL350247: Add file-based synchronization to flaky test (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56208?vs=179891&id=1

[Lldb-commits] [PATCH] D56208: Add file-based synchronization to flaky test

2019-01-02 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks Adrian, looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56208/new/ https://reviews.llvm.org/D56208 ___ lldb

[Lldb-commits] [PATCH] D56208: Add file-based synchronization to flaky test

2019-01-02 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl created this revision. aprantl added a reviewer: JDevlieghere. TestQueues is failing randomly on green dragon and I suspect it is because the enqueued threads haven't executed by the time we expect them. https://reviews.llvm.org/D56208 Files: packages/Python/lldbsuite/test/macosx/que