This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB350291: Simplify ObjectFile::GetArchitecture (authored by
labath, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D56129?vs=180008&id=180009#toc
Repository:
rLLDB LLDB
CHANGES S
labath updated this revision to Diff 180008.
labath added a comment.
Add unit test for ArchSpec::operator bool
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56129/new/
https://reviews.llvm.org/D56129
Files:
include/lldb/Core/Module.h
include/lldb/Expression/IRExecutionUnit.h
incl
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Maybe add a unit test for the operator bool? Otherwise this LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56129/new/
https://reviews.llvm.org/D56129
_
labath created this revision.
labath added reviewers: clayborg, zturner.
Herald added subscribers: JDevlieghere, arichardson, emaste.
Herald added a reviewer: espindola.
instead of returning the architecture through by-ref argument and a
boolean value indicating success, we can just return the Arc
