This revision was automatically updated to reflect the committed changes.
Closed by commit rL350809: PECOFF: Fix section name computation (authored by
labath, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D56124?vs=179644&id=181013#to
labath updated this revision to Diff 179644.
labath added a comment.
An excellent idea. Updating to use StringRef.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56124/new/
https://reviews.llvm.org/D56124
Files:
lit/Modules/PECOFF/sections-names.yaml
source
zturner added a comment.
What about just making this function return a StringRef?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56124/new/
https://reviews.llvm.org/D56124
___
lldb-commits mailing list
lldb-commits@
labath created this revision.
labath added reviewers: zturner, stella.stamenova.
Herald added a subscriber: abidh.
If a section name is exactly 8 bytes long (or has been truncated to 8
bytes), it will not contain the terminating nul character. This means
reading the name as a c string will p
