[Lldb-commits] [PATCH] D55706: ELF: more section creation cleanup

2018-12-15 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB349268: ELF: more section creation cleanup (authored by labath, committed by ). Herald added a subscriber: abidh. Changed prior to commit: https://reviews.llvm.org/D55706?vs=178231&id=178360#toc Rep

[Lldb-commits] [PATCH] D55706: ELF: more section creation cleanup

2018-12-15 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Kamil, Joerg: most of this is fairly lldb-specific and boring. I just added you for the .symtab thingy, just in case you know of anyone using SHT_SYMTAB sections which are not called .symtab (or conversely, using the name .symtab for non-symbol-table-related things). C

[Lldb-commits] [PATCH] D55706: ELF: more section creation cleanup

2018-12-14 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55706/new/ https://reviews.llvm.org/D55706 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D55706: ELF: more section creation cleanup

2018-12-14 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski edited reviewers, added: joerg; removed: krytarowski. krytarowski added a comment. I recommend joerg@ as a reviewer for ELF specifics. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55706/new/ https://reviews.llvm.org/D55706 ___

[Lldb-commits] [PATCH] D55706: ELF: more section creation cleanup

2018-12-14 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: clayborg, krytarowski. Herald added subscribers: arichardson, emaste. Herald added a reviewer: espindola. This patch attempts to move as much code as possible out of the CreateSections function to make room for future improvements there. Some o