[Lldb-commits] [PATCH] D55653: Check pointer results on nullptr before using them

JDevlieghere added a comment. In the future please include context with the diff (-U should do the trick), it makes reviewing a lot easier. Have you considered wrapping raw strings in llvm's `StringRef`s? It looks like lldb-mi is already using some ADT classes from llvm. Unfortunately we c

[Lldb-commits] [PATCH] D55653: Check pointer results on nullptr before using them

tatyana-krasnukha added a comment. Thanks for the review! Comment at: MIDataTypes.h:67 +template +class MIDereferenceable { +public: shafik wrote: > Can we use `llvm::Optional` instead? Then we can use `getValueOr()`. Unfortunately no, with `Optional` getValue

[Lldb-commits] [PATCH] D55653: Check pointer results on nullptr before using them

shafik added a comment. Looks like a great fix! Comment at: MIDataTypes.h:67 +template +class MIDereferenceable { +public: Can we use `llvm::Optional` instead? Then we can use `getValueOr()`. Comment at: MIDataTypes.h:71 + + T *Or(T &alt_va

[Lldb-commits] [PATCH] D55653: Check pointer results on nullptr before using them

tatyana-krasnukha updated this revision to Diff 186892. tatyana-krasnukha added a comment. Fixed misspelling CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55653/new/ https://reviews.llvm.org/D55653 Files: MICmdCmdGdbInfo.cpp MICmdCmdMiscellanous.cpp MICmnLLDBDebugSessionInfo.cpp

[Lldb-commits] [PATCH] D55653: Check pointer results on nullptr before using them

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: ki.stfu, abidh. Herald added a subscriber: lldb-commits. Prevent crashing like llvm.org/pr37054 Repository: rLLDB LLDB https://reviews.llvm.org/D55653 Files: MICmdCmdData.cpp MICmdCmdGdbInfo.cpp MICmdCmdMiscell