[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath added a comment. Thanks for the heads-up. This should be fixed in r350834. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55434/new/ https://reviews.llvm.org/D55434 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

sylvestre.ledru added a comment. On i386 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55434/new/ https://reviews.llvm.org/D55434 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

sylvestre.ledru added a comment. @labath This broke lldb on Debian stable: In file included from /build/llvm-toolchain-snapshot-8~svn350764/tools/lldb/source/Utility/DataExtractor.cpp:10: /build/llvm-toolchain-snapshot-8~svn350764/tools/lldb/include/lldb/Utility/DataExtractor.h:1099:29: er

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

This revision was automatically updated to reflect the committed changes. Closed by commit rL350511: ObjectFileBreakpad: Implement sections (authored by labath, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55434?vs=177209&id=180450#

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath accepted this revision. labath added a comment. Thank you for the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55434/new/ https://reviews.llvm.org/D55434 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath removed a reviewer: labath. labath added a comment. Removing the self-accept (oops). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55434/new/ https://reviews.llvm.org/D55434 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. You have convinced me! Sorry I had paged out the original intent you conveyed from before the break. Thanks for the details. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55434/ne

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath added a comment. I was under the impression I've convinced you of this direction, but your questions make it sound like you're going back to the "standalone" breakpad file idea (which I am not fond of). I'll try to explain again what I'm doing here. This is going to be somewhat repetitiv

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

clayborg added a comment. Just read the original description again and now code makes sense. Main questions for me: is there a benefit to creating multiple sections? Can we just create one section and name it ".breakpad"? Should we not try to find a section that contains the address from the FU

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

clayborg added a comment. So is this done as one section per function? Or one section for contiguous functions? What about if there are only symbols? I tried to read the code but wasn't able to decipher everything clearly in my head. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55434/

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath requested review of this revision. labath added a comment. Greg, given the intended usage of these sections as demonstrated in D56173 , do you agree with representing the sections of the breakpad object file in this way? CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath added a comment. I've uploaded D56173 to demonstrate how I intend to use the sections created here. The latter patch still requires some changes I only have locally (needed to make base address available to it), but the part about handling the sections

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath added a comment. In D55434#1325782 , @clayborg wrote: > Ok. Check out my changes that parse region info: > https://reviews.llvm.org/D55522 > > It parses the memory region info from the linux maps info if it is available. > In breakpad generated mi

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

clayborg added a comment. In D55434#1325739 , @labath wrote: > In D55434#1323912 , @clayborg wrote: > > > If you plan on not making the breakpad file ever stand alone, then you will > > need to take any addresses a

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath added a comment. In D55434#1323912 , @clayborg wrote: > If you plan on not making the breakpad file ever stand alone, then you will > need to take any addresses and look them up in the module section list and > use the other sections. I don't see

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

clayborg added a comment. If you plan on not making the breakpad file ever stand alone, then you will need to take any addresses and look them up in the module section list and use the other sections. I don't see why the breakpad file can't be stand alone though. It won't be as accurate, but it

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

clayborg added a comment. So we do something like you describe with the DYSM files. The object file is "a.out" and it has a dSYM file "a.out.dSYM/Context/Resources/DWARF/a.out" and the dSYM file will share sections with the "a.out" object file. So if you plan on loading the breakpad file as a s

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath added a comment. I guess I should elaborate more on the direction where I am going with this. I am trying to model these breakpad files as a debug-info-only object file, like something you would get by running say `strip --only-keep-debug`. This object file will contain a bunch of sectio

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

clayborg added a comment. Another point of clarification is that sections exist in order to lookup addresses and resolve addresses to a section within a file. The section should be something that can easily be slid around when loaded by LLDB when we are debugging or symbolicating. So any sectio

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So sections should correspond to different kinds of sections, like .text, .data, etc. If we have the following breakpad file: MODULE Linux x86_64 24B5D199F0F766FF5D

[Lldb-commits] [PATCH] D55434: ObjectFileBreakpad: Implement sections

labath created this revision. labath added reviewers: clayborg, zturner, lemo, markmentovai, amccarth. This patch allows ObjectFileBreakpad to parse the contents of Breakpad files into sections. This sounds slightly odd at first, but in essence its not too different from how other object files han