ted added a comment.
Herald added a project: LLDB.
@sgraenitz I've found an issue with this patch, using the Visual Studio 2015
generator.
In scripts/CMakeLists.txt the old code (for Windows):
if (CMAKE_CONFIGURATION_TYPES)
set(SWIG_PYTHON_DIR
${CMAKE_BINARY_DIR}/\${CMAKE_INSTALL_CONFIG_
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB350393: [CMake] Python bindings generation polishing
(authored by stefan.graenitz, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D55332?vs=177533&id=180232#toc
Repository:
rLLD
sgraenitz marked an inline comment as done.
sgraenitz added inline comments.
Comment at: CMakeLists.txt:134
--srcRoot=${LLDB_SOURCE_DIR}
- --targetDir=${LLDB_PYTHON_TARGET_DIR}
- --cfgBldDir=${LLDB_PYTHON_TARGET_DIR}
+ --t
sgraenitz updated this revision to Diff 177533.
sgraenitz marked 3 inline comments as done.
sgraenitz added a comment.
Address feedback and minor improvements
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55332/new/
https://reviews.llvm.org/D55332
Files:
CMakeLists.txt
scripts/CMak
sgraenitz marked an inline comment as done.
sgraenitz added inline comments.
Comment at: CMakeLists.txt:134
--srcRoot=${LLDB_SOURCE_DIR}
- --targetDir=${LLDB_PYTHON_TARGET_DIR}
- --cfgBldDir=${LLDB_PYTHON_TARGET_DIR}
+ --t
sgraenitz updated this revision to Diff 177516.
sgraenitz added a comment.
Account for changes in parent revision to keep individual commits compiling.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55332/new/
https://reviews.llvm.org/D55332
Files:
CMakeLists.txt
scripts/CMakeLists.
JDevlieghere added a comment.
This LGTM if it works on Windows.
Comment at: CMakeLists.txt:134
--srcRoot=${LLDB_SOURCE_DIR}
- --targetDir=${LLDB_PYTHON_TARGET_DIR}
- --cfgBldDir=${LLDB_PYTHON_TARGET_DIR}
+ --targetDir=$
sgraenitz added a comment.
Thanks for taking a look!
> It would be good to make sure that this works on mac, linux and windows all
> before you commit.
Shortly tested an in-tree lldb with clang, compiler-rt and lld on Windows using
the below config and successfully built the `BUILD_ALL` projec
stella.stamenova added inline comments.
Comment at: CMakeLists.txt:134
--srcRoot=${LLDB_SOURCE_DIR}
- --targetDir=${LLDB_PYTHON_TARGET_DIR}
- --cfgBldDir=${LLDB_PYTHON_TARGET_DIR}
+ --targetDir=$
+ --cfgBldDi
sgraenitz updated this revision to Diff 176957.
sgraenitz added a comment.
Avoid conflicts: updating diff for recent changes on master
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55332/new/
https://reviews.llvm.org/D55332
Files:
CMakeLists.txt
scripts/CMakeLists.txt
source/API/
sgraenitz marked an inline comment as done.
sgraenitz added inline comments.
Comment at: CMakeLists.txt:143
-DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/scripts/finishSwigWrapperClasses.py
-DEPENDS ${LLDB_PYTHON_TARGET_DIR}/lldb.py
COMMENT "Python script sym-link
sgraenitz created this revision.
sgraenitz added reviewers: JDevlieghere, aprantl, stella.stamenova, beanz,
zturner.
Herald added a subscriber: mgorny.
Simplify SWIG invocation and handling of generated files.
The `swig_wrapper` target can generate `LLDBWrapPython.cpp` and `lldb.py` in
its own
12 matches
Mail list logo
