[Lldb-commits] [PATCH] D55330: [CMake] Revised RPATH handling

This revision was automatically updated to reflect the committed changes. Closed by commit rL350392: [CMake] Revised RPATH handling (authored by stefan.graenitz, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[Lldb-commits] [PATCH] D55330: [CMake] Revised RPATH handling

sgraenitz marked 2 inline comments as done. sgraenitz added a comment. In D55330#1323525 , @xiaobai wrote: > Looks good to me overall. You also probably probably also invoke > `lldb_setup_rpaths_framework` for the tools included in the framework > (argdu

[Lldb-commits] [PATCH] D55330: [CMake] Revised RPATH handling

sgraenitz updated this revision to Diff 177512. sgraenitz added a comment. Rename function to setup rpaths and extend comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55330/new/ https://reviews.llvm.org/D55330 Files: cmake/modules/AddLLDB.cmake cmake/modules/LLDBConfig.cmake

[Lldb-commits] [PATCH] D55330: [CMake] Revised RPATH handling

xiaobai added a comment. Looks good to me overall. You also probably probably also invoke `lldb_setup_rpaths_framework` for the tools included in the framework (argdumper, darwin-debug, debugserver, lldb-server). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55330/new/ https://reviews

[Lldb-commits] [PATCH] D55330: [CMake] Revised RPATH handling

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM with the question answered/addressed. Thanks Stefan, these patches are really great work! Comment at: tools/driver/CMakeLists.txt:27 +if(LLDB_BUILD_FRAMEWOR

[Lldb-commits] [PATCH] D55330: [CMake] Revised RPATH handling

sgraenitz updated this revision to Diff 176956. sgraenitz added a comment. Avoid conflicts: updating diff for recent changes on master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55330/new/ https://reviews.llvm.org/D55330 Files: cmake/modules/AddLLDB.cmake cmake/modules/LLDBConfi

[Lldb-commits] [PATCH] D55330: [CMake] Revised RPATH handling

sgraenitz created this revision. sgraenitz added reviewers: xiaobai, JDevlieghere, aprantl, clayborg. Herald added subscribers: mgorny, ki.stfu. If we build LLDB.framework, dependant tools need appropriate RPATHs in both locations, the build-tree (for testing) and the install-tree (for deployment