[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

This revision was automatically updated to reflect the committed changes. Closed by commit rL350388: [CMake] Streamline code signing for debugserver #2 (authored by stefan.graenitz, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55013

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 177577. sgraenitz marked 2 inline comments as done. sgraenitz added a comment. Turn LLDB_CODESIGN_IDENTITY_USED variable from STRING into INTERNAL CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55013/new/ https://reviews.llvm.org/D55013 Files: C

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

labath accepted this revision. labath added a comment. This looks much better. Thanks. Comment at: tools/debugserver/source/CMakeLists.txt:104 +if(LLDB_CODESIGN_IDENTITY) + set(LLDB_CODESIGN_IDENTITY_USED ${LLDB_CODESIGN_IDENTITY} CACHE STRING "" FORCE) +elseif(LLVM_CODESIGNI

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz marked 9 inline comments as done. sgraenitz added inline comments. Comment at: CMakeLists.txt:141 if(TARGET debugserver) -if(NOT CMAKE_HOST_APPLE OR LLDB_CODESIGN_IDENTITY) - list(APPEND LLDB_TEST_DEPS debugserver) -endif() +list(APPEND LLDB_TEST_DEP

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 177486. sgraenitz added a comment. Avoid force-overwriting of LLVM_CODESIGNING_IDENTITY CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55013/new/ https://reviews.llvm.org/D55013 Files: CMakeLists.txt cmake/modules/AddLLDB.cmake cmake/modules

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz added a comment. Sorry for editing this again, but D55328 brought up an important change request (see https://reviews.llvm.org/D55328#anchor-1322655) and I only realized this side-effect afterwards: adding LLDB to a LLVM build tree (all with default

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 176949. sgraenitz added a comment. Avoid conflicts: updating diff for recent changes on master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55013/new/ https://reviews.llvm.org/D55013 Files: cmake/modules/AddLLDB.cmake cmake/modules/LLDBConfi

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Comment at: tools/debugserver/CMakeLists.txt:18 + + option(LLDB_USE_ENTITLEMENTS "When code signing, use entitlements if available" ON) + set(LLD

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz added inline comments. Comment at: tools/debugserver/CMakeLists.txt:18 + + option(LLDB_USE_ENTITLEMENTS "When code signing, use entitlements if available" ON) + set(LLDB_CODESIGN_IDENTITY lldb_codesign CACHE STRING JDevlieghere wrote: > sgraenitz wro

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

JDevlieghere added inline comments. Comment at: tools/debugserver/CMakeLists.txt:18 + + option(LLDB_USE_ENTITLEMENTS "When code signing, use entitlements if available" ON) + set(LLDB_CODESIGN_IDENTITY lldb_codesign CACHE STRING sgraenitz wrote: > JDevlieghere

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz added a comment. In-tree builds look good now. I successfully built and tested with these configurations: green dragon: xcrun cmake -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=On -DLLVM_ENABLE_MODULES=On ../llvm my default: xcrun cmake -GNinja -DCMAKE_BUILD_TYPE=Re

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz marked an inline comment as done. sgraenitz added a comment. Thanks for having a look. Comment at: tools/debugserver/CMakeLists.txt:18 + + option(LLDB_USE_ENTITLEMENTS "When code signing, use entitlements if available" ON) + set(LLDB_CODESIGN_IDENTITY lldb_codesign

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

JDevlieghere added inline comments. Comment at: tools/debugserver/CMakeLists.txt:18 + + option(LLDB_USE_ENTITLEMENTS "When code signing, use entitlements if available" ON) + set(LLDB_CODESIGN_IDENTITY lldb_codesign CACHE STRING Why do we need to define this op

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 175739. sgraenitz added a comment. Move code sign settings to LLDBConfig.cmake CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55013/new/ https://reviews.llvm.org/D55013 Files: cmake/modules/AddLLDB.cmake cmake/modules/LLDBConfig.cmake test/C

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 175736. sgraenitz added a comment. Default identity for code signing must be lldb_codesign. Also remove the comment to deprecate LLDB_CODESIGN_IDENTITY in favor of LLVM_CODESIGNING_IDENTITY. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55013/new

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz updated this revision to Diff 175734. sgraenitz added a comment. Fix target directory for debugserver: it must not be LLVM_TOOLS_BINARY_DIR but LLVM_RUNTIME_OUTPUT_INTDIR. It's a difference in standalone builds of LLDB. LLVM_TOOLS_BINARY_DIR was wrong here as it points to the binary di

[Lldb-commits] [PATCH] D55013: [CMake] Streamline code signing for debugserver #2

sgraenitz created this revision. Herald added a subscriber: mgorny. The first patch had to be reverted as I missed a few details. This review continues from D54476 and I will add the required fixes. Change log: - Use llvm_codesign to sign debugserver with enti