jingham added a comment.
As for testing, Jason was careful to use a WP, so nothing crashes. The
process's SP doesn't resolve and then you get the default setting of any
process specific setting that uses the ABI. Since there aren't any of those
yet - this currently has no observable consequen
jingham added a comment.
Okay, I think I'll keep what Jason did and just make them per-process. As Greg
said, they are very cheap to make, since they just take a Process SP and get
the weak pointer from it. None of them have any other state.
Repository:
rLLDB LLDB
https://reviews.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB346775: Since ABI's now hold a process WP, they
should be handed (authored by jingham, committed by ).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54460
Files:
source/Plugins/ABI/MacOSX-arm/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL346775: Since ABI's now hold a process WP, they should
be handed (authored by jingham, committed by ).
Herald added subscribers: llvm-commits, jrtc27.
Changed prior to commit:
https://reviews.llvm.org/D
clayborg added a comment.
Anything that takes a process shared pointer should be per process. A long time
ago these plug-ins didn't take process, and as time went on they did take a
process:
306633 jmolenda ABI(lldb::ProcessSP process_sp) {
306633 jmolenda if (process_sp.get())
zturner added a comment.
> If there were ever anything per-process that effected the ABI plugin's
> behavior (for instance if it relied on a Process property) you could very
> well use the wrong processes setting. Even worse, since the ABI's hold onto a
> process through a weak pointer, if the
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
LGTM, my guess is that this was Greg's code originally. He may have made a
singleton object out of caution.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D54460
_
jingham created this revision.
jingham added reviewers: clayborg, jasonmolenda.
Herald added subscribers: lldb-commits, abidh, atanasyan, kbarton, javed.absar,
nemanjai.
For reasons that are unclear to me, when the ABIXXX::CreateInstance function is
called to make a new ABI for a given process a
