[Lldb-commits] [PATCH] D54417: Fix a crash when parsing incorrect DWARF

2018-11-14 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB346849: Fix a crash when parsing incorrect DWARF (authored by labath, committed by ). Herald added a subscriber: abidh. Changed prior to commit: https://reviews.llvm.org/D54417?vs=173634&id=174006#to

[Lldb-commits] [PATCH] D54417: Fix a crash when parsing incorrect DWARF

2018-11-12 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Your explanation makes sense, good catch. Thanks for fixing this! https://reviews.llvm.org/D54417 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D54417: Fix a crash when parsing incorrect DWARF

2018-11-12 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: clayborg, jankratochvil, JDevlieghere. While parsing a childless compile unit DIE we could crash if the DIE was followed by any extra data (such as a superfluous end-of-children marker). This happened because the break-on-depth=0 check was perf