[Lldb-commits] [PATCH] D54385: Remove comments after header includes.

2018-11-11 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In https://reviews.llvm.org/D54385#1294534, @teemperor wrote: > Do we also want to get rid of the `// C Includes` comments that are in some > files? LLVM isn't using them either and just removing lines doesn't make git > blame more complicated. Yup, I'll do that

[Lldb-commits] [PATCH] D54385: Remove comments after header includes.

2018-11-11 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Do we also want to get rid of the `// C Includes` comments that are in some files? LLVM isn't using them either and just removing lines doesn't make git blame more complicated. Comment at: source/Plugins/Instruction/MIPS/EmulateInstructionMIPS.cpp:3

[Lldb-commits] [PATCH] D54385: Remove comments after header includes.

2018-11-10 Thread Vedant Kumar via Phabricator via lldb-commits
vsk accepted this revision as: vsk. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. Repository: rLLDB LLDB https://reviews.llvm.org/D54385 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.