tberghammer added inline comments.
Comment at: tools/lldb-test/SystemInitializerTest.cpp:194
SystemRuntimeMacOSX::Initialize();
RenderScriptRuntime::Initialize();
- JavaLanguageRuntime::Initialize();
davide wrote:
> Aside, do you know why we have renderscr
davide added inline comments.
Comment at: tools/lldb-test/SystemInitializerTest.cpp:194
SystemRuntimeMacOSX::Initialize();
RenderScriptRuntime::Initialize();
- JavaLanguageRuntime::Initialize();
Aside, do you know why we have renderscript support? maybe th
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
LGTM. Thank you for removing it.
Comment at: source/Plugins/Process/minidump/MinidumpTypes.h:84
Token = 19,
- JavascriptData = 20,
SystemMemoryInfo = 21,
---
JDevlieghere added a comment.
In https://reviews.llvm.org/D54059#1286293, @teemperor wrote:
> Minor detail: The revision title only mentions Java, but this revision
> removes both Go and Java.
Actually, this review is only for removing the Java plugin. There’s a different
review for the Go pl
teemperor added a comment.
Minor detail: The revision title only mentions Java, but this revision removes
both Go and Java.
Did anyone actually went through with Jim's proposal and posted this proposal
to some Go mailing list or so?
https://reviews.llvm.org/D54059
_
