This revision was automatically updated to reflect the committed changes.
Closed by commit rL345812: [FileSystem] Remove GetByteSize() from FileSpec
(authored by JDevlieghere, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D53788?vs=17
zturner added a comment.
In https://reviews.llvm.org/D53788#1279096, @shafik wrote:
> Are we refactoring in the right place? Why not just refactor
> `FileSpec::GetByteSize()` why is `FileSpec` the wrong place?
There was another review thread where we discussed this just the other day.
Basica
shafik added a comment.
Are we refactoring in the right place? Why not just refactor
`FileSpec::GetByteSize()` why is `FileSpec` the wrong place?
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:718
+ (FileSystem::Instance().GetByteSize(file) - file
JDevlieghere added a comment.
In https://reviews.llvm.org/D53788#1278036, @zturner wrote:
> I always wondered if we actually even need methods like this in `FileSystem`
> given that they already exist in `llvm::sys::fs`. Is it possible to just
> call the llvm methods directly, or is it still h
zturner accepted this revision.
zturner added a comment.
I always wondered if we actually even need methods like this in `FileSystem`
given that they already exist in `llvm::sys::fs`. Is it possible to just call
the llvm methods directly, or is it still helpful to call the ones in
`FileSystem`
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rLLDB LLDB
https://reviews.llvm.org/D53788
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cg
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, zturner, jingham.
JDevlieghere added a project: LLDB.
Herald added subscribers: arichardson, emaste.
Herald added a reviewer: espindola.
This patch removes the `GetByteSize` method from FileSpec and updates its uses
with ca
