aleksandr.urakov added a comment.
Yes, it's simpler to move it to the `CPlusPlusLanguage::MethodName` (or
`CPlusPlusNameParser`?) I think. The only question left is how to differentiate
MSVC demangled names from others? May be it would be ok to treat name as an
MSVC name if it contains a grave
labath added a comment.
In https://reviews.llvm.org/D52461#1266302, @aleksandr.urakov wrote:
> `operator<'::`2'::B::operator>
>
The reason we had to use clang lexer for parsing itanium names is because
parsing itanium demangled names is tricky precisely for cases like these. If
the MSVC dem
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D52461#1265633, @zturner wrote:
> Just handle the `anonymous namespace' thing specially before passing to
> `CPlusPlusNameParser`.
Yes, it's an interesting idea to somehow preprocess an MSVC demangled name and
make a GCC demangled
zturner added a comment.
In https://reviews.llvm.org/D52461#1265335, @aleksandr.urakov wrote:
> Hello!
>
> I just have tried to patch `CPlusPlusNameParser` in the way to support MSVC
> demangled names, but there is a problem. `CPlusPlusNameParser` splits an
> incoming name in tokens with `clang
aleksandr.urakov added a subscriber: labath.
aleksandr.urakov added a comment.
Hello!
I just have tried to patch `CPlusPlusNameParser` in the way to support MSVC
demangled names, but there is a problem. `CPlusPlusNameParser` splits an
incoming name in tokens with `clang::Lexer`. I've lexed the
labath added a comment.
In https://reviews.llvm.org/D52461#1250555, @aleksandr.urakov wrote:
> I've tried to parse with it a name like
>
> N0::`unnamed namespase'::Name
>
>
> and it can't parse it correctly. May be it just can't parse MSVC demangled
> names?
I expect the backqoutes are confu
aleksandr.urakov added a comment.
I've tried to parse with it a name like
N0::`unnamed namespase'::Name
and it can't parse it correctly. May be it just can't parse MSVC demangled
names?
Unfortunately, I can't look at the tests right now, I have a vacation. I'll
look at these a week later, o
labath added a comment.
In https://reviews.llvm.org/D52461#1249259, @aleksandr.urakov wrote:
> It seems that `CPlusPlusLanguage::MethodName` is backed by LLDB
> `CPlusPlusNameParser`, which can't parse demangled names...
What makes you say that? If you look at the MethodName unit tests
(`unit
aleksandr.urakov added a comment.
Ok, I'll look at this, thank you!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52461
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Hui added a comment.
In https://reviews.llvm.org/D52461#1249259, @aleksandr.urakov wrote:
> In https://reviews.llvm.org/D52461#1245058, @clayborg wrote:
>
> > Try to use and extend CPlusPlusLanguage::MethodName as needed. I believe it
> > was recently backed by a new clang parser that knows how
aleksandr.urakov added a reviewer: clayborg.
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D52461#1245058, @clayborg wrote:
> Try to use and extend CPlusPlusLanguage::MethodName as needed. I believe it
> was recently backed by a new clang parser that knows how to chop up C++
> d
aleksandr.urakov added a comment.
Ok, I'll look into that, thanks!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52461
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added a comment.
In https://reviews.llvm.org/D52461#1244813, @labath wrote:
> I think you should look at CPlusPlusLanguage::MethodName. It already contains
> a parser (in fact, two of them) of c++ names, and I think it should be easy
> to extend it to do what you want.
I agree with P
labath added a comment.
I think you should look at CPlusPlusLanguage::MethodName. It already contains a
parser (in fact, two of them) of c++ names, and I think it should be easy to
extend it to do what you want.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52461
_
aleksandr.urakov created this revision.
aleksandr.urakov added reviewers: zturner, asmith, labath.
aleksandr.urakov added a project: LLDB.
Herald added subscribers: lldb-commits, teemperor, mgorny.
This patch introduces the simple `PDBNameParser`. It is needed for parsing
names of PDB symbols cor
15 matches
Mail list logo
