[Lldb-commits] [PATCH] D52404: Prevent double import of _lldb module

2018-10-14 Thread Vadim Chugunov via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL344474: Fix double import of _lldb module. (authored by vadimcn, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52404?vs=166627&id=169595#toc

[Lldb-commits] [PATCH] D52404: Prevent double import of _lldb module

2018-10-07 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In https://reviews.llvm.org/D52404#1257347, @vadimcn wrote: > Thanks, > What changed in SWIG 3.0.11? That's the version which added support for the `moduleimport` attribute. Before that, the modules were imported using a fixed algorithm (I am not sure whether that alg

[Lldb-commits] [PATCH] D52404: Prevent double import of _lldb module

2018-10-07 Thread Vadim Chugunov via Phabricator via lldb-commits
vadimcn added a comment. Thanks, What changed in SWIG 3.0.11? Repository: rLLDB LLDB https://reviews.llvm.org/D52404 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52404: Prevent double import of _lldb module

2018-10-06 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sorry for the delay. I *think* this should be fine, but with these things its hard to tell whether it won't break someone's build/release setup. However, it does solve a real problem (I've hit

[Lldb-commits] [PATCH] D52404: Prevent double import of _lldb module

2018-10-06 Thread Vadim Chugunov via Phabricator via lldb-commits
vadimcn added a comment. Changing title as it looks like this is not a Windows-only problem: https://github.com/rust-lang/rust/issues/54126. The above illustrates why I think this needs to be fixed: Right now LLDB cannot be installed correctly unless the installer can preserve symlinks. Merely