[Lldb-commits] [PATCH] D52065: WWW docs for scripted breakpoint resolvers

2018-09-17 Thread Jim Ingham via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL342419: Add docs for scripted breakpoint resolvers (authored by jingham, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52065?vs=165796&id=16

[Lldb-commits] [PATCH] D52065: WWW docs for scripted breakpoint resolvers

2018-09-17 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for doing all the updates. Pretty clear and concise now. Repository: rLLDB LLDB https://reviews.llvm.org/D52065 ___ lldb-commits ma

[Lldb-commits] [PATCH] D52065: WWW docs for scripted breakpoint resolvers

2018-09-17 Thread Jim Ingham via Phabricator via lldb-commits
jingham updated this revision to Diff 165796. jingham marked 3 inline comments as done. jingham added a comment. Addressed review comments from Greg. Repository: rLLDB LLDB https://reviews.llvm.org/D52065 Files: www/python-reference.html Index: www/python-reference.html ==

[Lldb-commits] [PATCH] D52065: WWW docs for scripted breakpoint resolvers

2018-09-17 Thread Jim Ingham via Phabricator via lldb-commits
jingham marked 3 inline comments as done. jingham added a comment. I used your suggestion and fixed the few other bits. Comment at: www/python-reference.html:325 +Another use of the Python API's in lldb is to create a custom breakpoint resolver. This facility

[Lldb-commits] [PATCH] D52065: WWW docs for scripted breakpoint resolvers

2018-09-17 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added inline comments. Comment at: www/python-reference.html:325 +Another use of the Python API's in lldb is to create a custom breakpoint resolver. This facility + was added in r51967. + Is that SVN r

[Lldb-commits] [PATCH] D52065: WWW docs for scripted breakpoint resolvers

2018-09-14 Thread Jim Ingham via Phabricator via lldb-commits
jingham updated this revision to Diff 165614. jingham added a comment. I think this should address your concerns, though I did so more by reworking the presentation, so you won't find inserts exactly at the places you pointed out. But I tried to make it clear that you only write the Resolver, a

[Lldb-commits] [PATCH] D52065: WWW docs for scripted breakpoint resolvers

2018-09-14 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. See inlined comments. Comment at: www/python-reference.html:324 + +Another use of the Python API's in lldb is to create a custom breakpoint resolver. This + allows you to implement your own logic to search the space

[Lldb-commits] [PATCH] D52065: WWW docs for scripted breakpoint resolvers

2018-09-13 Thread Jim Ingham via Phabricator via lldb-commits
jingham created this revision. jingham added a reviewer: clayborg. Herald added subscribers: lldb-commits, abidh. These are the promised docs for https://reviews.llvm.org/D51830. Repository: rLLDB LLDB https://reviews.llvm.org/D52065 Files: www/python-reference.html Index: www/python-refe