This revision was automatically updated to reflect the committed changes.
Closed by commit rL342042: Add a basic test for 'memory region'
(authored by teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51930?vs=164862&id=165045
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
Yeah, sure :)
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51930
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.ll
vsk added a comment.
This LGTM. Davide?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51930
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
vsk added a comment.
I think it'd be useful to test the driver output specifically. The kind of
testing lldb-test facilitates might not be a good fit here (too low-level).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51930
___
lldb-commits m
davide added a comment.
Yeah, that's the revision I had in mind. Can't you extend `lldb-test` to do
what you need?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51930
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm
teemperor added a subscriber: vsk.
teemperor added a comment.
@davide Maybe git is failing me, but I can only find
https://reviews.llvm.org/D47508 but that doesn't seem related. Let's ping @vsk
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51930
davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.
I thought Vedant added an harness utility to test memory a bit ago. Have you
looked into whether that's extensible for your purposes, Raphael?
Repository:
rLLDB LLDB
https://revi
teemperor created this revision.
teemperor added a reviewer: LLDB.
Herald added a subscriber: lldb-commits.
The 'memory region' command is at the moment not tested at all by our test
suite.
This patch just adds a basic test that at least provides some basic testing.
Repository:
rLLDB LLDB
ht
