jingham marked an inline comment as done.
jingham added inline comments.
Comment at: source/Core/SearchFilter.cpp:757
+ }
+ if (m_cu_spec_list.FindFileIndex(0, sym_ctx.comp_unit, false) == UINT32_MAX)
+return false; // Fails the file check
kwk wrote:
>
kwk added inline comments.
Comment at: source/Core/SearchFilter.cpp:757
+ }
+ if (m_cu_spec_list.FindFileIndex(0, sym_ctx.comp_unit, false) == UINT32_MAX)
+return false; // Fails the file check
@jingham Do you know why you check for the CU again here? I
This revision was automatically updated to reflect the committed changes.
Closed by commit rL342185: Add a "scripted" breakpoint type to lldb.
(authored by jingham, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51830?vs=165184&id=165
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB342185: Add a "scripted" breakpoint type to
lldb. (authored by jingham, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D51830?vs=165184&id=165386#toc
Repository:
rLLDB LLDB
htt
jingham updated this revision to Diff 165184.
jingham added a comment.
Add documentation for SBTarget.CreateBreakpointFromScript, and fixed a few
minor nits that Greg pointed out.
https://reviews.llvm.org/D51830
Files:
include/lldb/API/SBAddress.h
include/lldb/API/SBBreakpoint.h
include/
jingham added a comment.
I addressed most of the comments. I remember we argued about how the filters
should work w.r.t. the resolvers back when I first did this, but I still claim
my way is right ;-) I gave some arguments for that in response to your inline
comment.
I'm going to save this (
clayborg added a comment.
Only issue now is documentation and why are we requiring addresses to be in
compile unit. See inlined comments.
Comment at: include/lldb/API/SBTarget.h:667
+ lldb::SBBreakpoint BreakpointCreateFromScript(
+ const char *class_name,
+ SBStruc
jingham added a comment.
I addressed the individual concerns in the comments. There were a couple of
overall points:
1. Could we avoid adding AddLocation by having the callback return a list of
addresses to set breakpoints. I actually like directly saying "Set me a
location there" and I have
clayborg added a comment.
See inlined comments. Cool stuff.
Comment at: include/lldb/API/SBBreakpoint.h:26-27
+ SBBreakpoint(const lldb::BreakpointSP &bp_sp);
+
~SBBreakpoint();
Why does this need to be public?
Comment at: include/lldb/
jingham added a comment.
Thanks for adding Greg. I am the code owner for the breakpoints part of lldb,
and most recently I've been the only one adding to the scripting interface.
There wasn't another really germane reviewer, and since the dev list was CC'ed
I figured if anybody was interested
kristina added subscribers: clayborg, kristina.
kristina added a reviewer: clayborg.
kristina added a comment.
Please add code reviewers to your differentials when you make them especially
when they're this big, at the very least the code owner for that particular
project should be added. I adde
jingham created this revision.
Herald added subscribers: lldb-commits, teemperor, abidh, jfb, srhines.
This change allows you to make a breakpoint resolver kernel in Python.
The breakpoint search mechanism in lldb works on top of a generic mechanism
that uses a pair of Searcher - with its associ
12 matches
Mail list logo
