[Lldb-commits] [PATCH] D51600: [NFC] Fixed enum constant in boolean context error

2018-09-04 Thread Dávid Bolvanský via Phabricator via lldb-commits
xbolva00 added a comment. Ok, I messed up my LLDB svn a bit yesterday so probably I have found reason of that strange behavior. I will re-setup it locally. Thanks. Repository: rLLDB LLDB https://reviews.llvm.org/D51600 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D51600: [NFC] Fixed enum constant in boolean context error

2018-09-04 Thread Dávid Bolvanský via Phabricator via lldb-commits
xbolva00 added a comment. In https://reviews.llvm.org/D51600#1223303, @clayborg wrote: > If you insert the text: > > Differential Revision: https://reviews.llvm.org/D51600 > > > Into your commit it will automatically show the SVN revision that was used > for the commit. Can you attach the SVN

[Lldb-commits] [PATCH] D51600: [NFC] Fixed enum constant in boolean context error

2018-09-04 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. (you can also try arcanist which will do this automatically for you) Repository: rLLDB LLDB https://reviews.llvm.org/D51600 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [PATCH] D51600: [NFC] Fixed enum constant in boolean context error

2018-09-04 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. If you insert the text: Differential Revision: https://reviews.llvm.org/D51600 Into your commit it will automatically show the SVN revision that was used for the commit. Can you attach the SVN revision to this as a comment so we can track this? Repository: rLLDB

[Lldb-commits] [PATCH] D51600: [NFC] Fixed enum constant in boolean context error

2018-09-03 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. This whole code doesn't seem to have test coverage, so I'll not demand a test for this. Also this patch is clearly fixing a typo, so let's get this in. Repository: rLLDB LLDB https:/

[Lldb-commits] [PATCH] D51600: [NFC] Fixed enum constant in boolean context error

2018-09-03 Thread Dávid Bolvanský via Phabricator via lldb-commits
xbolva00 created this revision. xbolva00 added a reviewer: JDevlieghere. Herald added subscribers: lldb-commits, abidh. /home/xbolva00/LLVM/llvm/tools/lldb/source/Plugins/DynamicLoader/Darwin-Kernel/DynamicLoaderDarwinKernel.cpp:656:59: warning: enum constant in boolean context [-Wint-in-bool-con