[Lldb-commits] [PATCH] D51591: [PseudoTerminal][NFC] Use llvm errno helpers

2018-09-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM, thx! https://reviews.llvm.org/D51591 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[Lldb-commits] [PATCH] D51591: [PseudoTerminal][NFC] Use llvm errno helpers

2018-09-03 Thread Dávid Bolvanský via Phabricator via lldb-commits
xbolva00 updated this revision to Diff 163712. xbolva00 added a comment. - Added helper function https://reviews.llvm.org/D51591 Files: source/Host/common/PseudoTerminal.cpp Index: source/Host/common/PseudoTerminal.cpp === --- s

[Lldb-commits] [PATCH] D51591: [PseudoTerminal][NFC] Use llvm errno helpers

2018-09-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Any chance we could wrap this in a helper function? https://reviews.llvm.org/D51591 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits