[Lldb-commits] [PATCH] D51185: Reuse the SelectorTable from Clang's Preprocessor

2018-08-23 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB340585: Reuse the SelectorTable from Clang's Preprocessor (authored by teemperor, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D51185 Files: source/Plugins/ExpressionParser/Cla

[Lldb-commits] [PATCH] D51185: Reuse the SelectorTable from Clang's Preprocessor

2018-08-23 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. Yeah, but the FIXME has been around for like a decade, so I think that bug has survived long enough to be promoted to a feature :). Repository: rLLDB LLDB https://reviews.llvm.org/D51185 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D51185: Reuse the SelectorTable from Clang's Preprocessor

2018-08-23 Thread Vedant Kumar via Phabricator via lldb-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM. This is NFC, it seems. There's a FIXME in Preprocessor.h about the lifetime of SelectorTable eventually not being tied to Preprocessor, but this is correct for now. Repository: rLLDB LLDB