[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

2020-02-14 Thread Alexander Polyakov via Phabricator via lldb-commits
apolyakov abandoned this revision. apolyakov added a comment. Herald added a subscriber: JDevlieghere. Abandoned since the patch is outdated too much. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50525/new/ https://reviews.llvm.org/D50525 __

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

2018-08-10 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s labath wrote: > aprantl wrote: > > stella.stamenova wrote: > > >

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

2018-08-10 Thread Paul Robinson via Phabricator via lldb-commits
probinson added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/target-list.test:5 +# We should hardcode executable name since at the moment of running of +# lldb-mi the name must be known. +# RUN: %cxx -o a.exe %p/inputs/main.cpp -g aprant

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

2018-08-10 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s aprantl wrote: > stella.stamenova wrote: > > apolyakov wrote: > > > stella

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

2018-08-09 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s stella.stamenova wrote: > apolyakov wrote: > > stella.stamenova wrote: >

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

2018-08-09 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova requested changes to this revision. stella.stamenova added inline comments. This revision now requires changes to proceed. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t <

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

2018-08-09 Thread Alexander Polyakov via Phabricator via lldb-commits
apolyakov added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/target-list.test:18 +target list +# CHECK: ~"Current targets:\n* target #0: {{.*}}a.exe{{.*}}\n" + aprantl wrote: > Does lldb-mi echo the comment lines? If yes, you need to be

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

2018-08-09 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/target-list.test:5 +# We should hardcode executable name since at the moment of running of +# lldb-mi the name must be known. +# RUN: %cxx -o a.exe %p/inputs/main.cpp -g That's t

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

2018-08-09 Thread Alexander Polyakov via Phabricator via lldb-commits
apolyakov added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s stella.stamenova wrote: > apolyakov wrote: > > stella.stamenova wrote:

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

2018-08-09 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s apolyakov wrote: > stella.stamenova wrote: > > One thing to cons

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

2018-08-09 Thread Alexander Polyakov via Phabricator via lldb-commits
apolyakov added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s stella.stamenova wrote: > One thing to consider here is that any extra

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

2018-08-09 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s One thing to consider here is that any extra parameters passed w

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

2018-08-09 Thread Alexander Polyakov via Phabricator via lldb-commits
apolyakov created this revision. apolyakov added reviewers: aprantl, clayborg, jingham, labath. Herald added a subscriber: ki.stfu. In this patch I move some of interpreter tests from python to LIT(I will move all interpreter test if these are OK). It's a WIP since I want to get your opinion abo