This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB341089: Move Predicate.h from Host to Utility (authored
by teemperor, committed by ).
Herald added a subscriber: jfb.
Changed prior to commit:
https://reviews.llvm.org/D50384?vs=159649&id=163371#toc
labath added a comment.
Also, to answer Zachary's question:
A lot of the existing uses of Predicate class could be replaced by
`std::future` (often `future`). The one in the Event class is in this
category. However, there are some uses (these tend to be hacks of various
magnitudes), which are
labath added a comment.
Not blocked on anything, just haven't gotten around to committing it yet. Feel
free to land it for me.
https://reviews.llvm.org/D50384
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
teemperor added a comment.
Is this blocked by something? If you're busy @labath I can commit this and
watch the bots.
https://reviews.llvm.org/D50384
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
lgtm, although Predicate is simple enough that I wonder if one day we should
try to just delete it entirely.
https://reviews.llvm.org/D50384
_
labath updated this revision to Diff 159649.
labath added a comment.
Updating the module map too (thanks).
https://reviews.llvm.org/D50384
Files:
include/lldb/Core/Event.h
include/lldb/Core/IOHandler.h
include/lldb/Host/Editline.h
include/lldb/Host/Predicate.h
include/lldb/Host/Socket
xiaobai added a comment.
Hurray for more layering improvements!
It looks like Raphael recently committed a modulemap for compiling the LLDB
headers into C++ modules (`include/lldb/module.modulemap`) that has a reference
to Predicate.h in in Host. You should probably modify that as well.
https
labath created this revision.
labath added reviewers: jingham, zturner, teemperor.
Herald added a subscriber: mgorny.
This class was initially in Host because its implementation used to be
very OS-specific. However, with C++11, it has become a very simple
std::condition_variable wrapper, with no h
