This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB342050: Move SafeMachO from Utility to Host (authored by
labath, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D50383?vs=165058&id=165070#toc
Repository:
rLLDB LLDB
https://re
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
https://reviews.llvm.org/D50383
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
labath updated this revision to Diff 165058.
labath added a comment.
Add the file to module map.
https://reviews.llvm.org/D50383
Files:
include/lldb/Host/SafeMachO.h
include/lldb/Utility/SafeMachO.h
include/lldb/module.modulemap
source/Host/common/Symbols.cpp
source/Host/macosx/Symbol
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
Please add the header also to the modulemap in Host (which has to be manually
written, as the Host module contains a lot of OS-specific headers):
`module SafeMachO { header "Hos
labath created this revision.
labath added reviewers: jingham, zturner, teemperor.
Herald added a subscriber: fedor.sergeev.
One of the conclusions of the discussion on https://reviews.llvm.org/D49740 was
that SafeMachO is better
off in the Host module (as that's the only place which should inclu
