sgraenitz added a comment.
> This is another one of classes we should probably get rid of (it looks like
> all of this functionality is available in StringRef)
Late +1. Usage in `FormattersContainer.h` should be easy to replace. Apart form
that it could be an implementation detail of `AppleObjC
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340448: Add unit test for StringLexer (authored by
teemperor, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50298?vs=159193&id=162038#toc
R
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
This is another one of classes we should probably get rid of (it looks like all
of this functionality is available in StringRef), but while we have it, it
might as well be tested.
https://re
teemperor updated this revision to Diff 159193.
teemperor added a comment.
- Fixed typo (Thanks Joe!)
https://reviews.llvm.org/D50298
Files:
unittests/Utility/CMakeLists.txt
unittests/Utility/StringLexerTest.cpp
Index: unittests/Utility/StringLexerTest.cpp
=
jloser added inline comments.
Comment at: unittests/Utility/StringLexerTest.cpp:25
+
+TEST(StringLexerTest, HasAtLest) {
+ StringLexer l("foo");
Nit: typo in the test case name.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50298
teemperor created this revision.
teemperor added a reviewer: labath.
Herald added a subscriber: mgorny.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50298
Files:
unittests/Utility/CMakeLists.txt
unittests/Utility/StringLexerTest.cpp
Index: unittests/Utility/StringLexerTest.cpp
===
