[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

This revision was automatically updated to reflect the committed changes. Closed by commit rL339161: Misc module/dwarf logging improvements (authored by lemo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50274?vs=159432&id=159551#to

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413 +section->GetName().GetCString(), +llvm::toString(Decompressor.takeError()).c_str()); +

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

lemo added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413 +section->GetName().GetCString(), +llvm::toString(Decompressor.takeError()).c_str()); +return 0; labath wrote: > lemo wrote: > > labath wrote: > > > T

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

lemo updated this revision to Diff 159432. lemo marked an inline comment as done. lemo added a comment. Updated the LIT file too https://reviews.llvm.org/D50274 Files: lit/Modules/compressed-sections.yaml source/Core/Module.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp source/Plug

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

labath added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413 +section->GetName().GetCString(), +llvm::toString(Decompressor.takeError()).c_str()); +return 0; lemo wrote: > labath wrote: > > This needs to be `s

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

lemo added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413 +section->GetName().GetCString(), +llvm::toString(Decompressor.takeError()).c_str()); +return 0; labath wrote: > This needs to be `std::move(Error)`.

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

labath added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413 +section->GetName().GetCString()); +return 0; } lemo wrote: > labath wrote: > > `lit/Modules/compressed-sections.yaml` test will need to be updated to >

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

lemo marked 2 inline comments as done. lemo added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3413 +section->GetName().GetCString()); +return 0; } labath wrote: > `lit/Modules/compressed-sections.yaml` test will nee

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

lemo updated this revision to Diff 159368. lemo added a comment. Incorporating feedback, thanks. https://reviews.llvm.org/D50274 Files: source/Core/Module.cpp source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp source/Plugins/Process/minidump/ProcessMinidump.cpp source/Target/Process.cpp I

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

clayborg added a comment. LGTM after Pavel's inline comments are addressed. Repository: rLLDB LLDB https://reviews.llvm.org/D50274 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

labath added inline comments. Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3400-3403 +GetModule()->ReportWarning( +"Unable to initialize decompressor for section '%s'", +section->GetName().GetCString()); +return 0; You have

[Lldb-commits] [PATCH] D50274: Misc module/dwarf logging improvements

lemo created this revision. lemo added reviewers: labath, clayborg. lemo added a project: LLDB. Herald added subscribers: JDevlieghere, arichardson, aprantl, emaste. Herald added a reviewer: espindola. This change improves the logging for the lldb.module category to note a few interesting cases: