[Lldb-commits] [PATCH] D50155: Delete MacOSXFrameBackchain unwind logic (NFC)

2018-10-22 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Sorry for not replying to this. Yes the code is unused - it was the initial unwinder implementation when lldb is very young, before we had our current one. The main reason to kee

[Lldb-commits] [PATCH] D50155: Delete MacOSXFrameBackchain unwind logic (NFC)

2018-10-04 Thread Vedant Kumar via Phabricator via lldb-commits
vsk added a comment. Ping? https://reviews.llvm.org/D50155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D50155: Delete MacOSXFrameBackchain unwind logic (NFC)

2018-08-01 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. Deleting dead code is always good; I'll let Jason sign this off though. https://reviews.llvm.org/D50155 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D50155: Delete MacOSXFrameBackchain unwind logic (NFC)

2018-08-01 Thread Vedant Kumar via Phabricator via lldb-commits
vsk created this revision. vsk added reviewers: aprantl, jasonmolenda. Herald added subscribers: chrib, krytarowski, mgorny, srhines. This code looks like a good reference for building a new unwinder, but is currently unused, so there's no need to keep it. https://reviews.llvm.org/D50155 Files: