This revision was automatically updated to reflect the committed changes.
Closed by commit rL338058: Make framework-header-fix process copied headers
(authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49779
Files:
lld
keith added a comment.
No problem! Yes please! :)
https://reviews.llvm.org/D49779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
xiaobai accepted this revision.
xiaobai added a comment.
This revision is now accepted and ready to land.
Awesome! Thank you so much for your patience and contribution. :)
Do you need somebody to commit this for you?
https://reviews.llvm.org/D49779
___
keith added inline comments.
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
xiaobai wrote:
> keith wrote:
> > xiaobai wrote:
keith updated this revision to Diff 157547.
keith added a comment.
- Hoist LLDB.framework headers copy out of condition
https://reviews.llvm.org/D49779
Files:
cmake/modules/LLDBFramework.cmake
Index: cmake/modules/LLDBFramework.cmake
=
xiaobai added inline comments.
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
keith wrote:
> xiaobai wrote:
> > keith wrote:
keith added inline comments.
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
xiaobai wrote:
> keith wrote:
> > xiaobai wrote:
xiaobai added inline comments.
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
keith wrote:
> xiaobai wrote:
> > keith wrote:
keith added inline comments.
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
xiaobai wrote:
> keith wrote:
> > xiaobai wrote:
xiaobai added a comment.
Looks good
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
keith wrote:
> xiaobai wrote:
> > This s
keith added inline comments.
Comment at: cmake/modules/LLDBFramework.cmake:41
+add_custom_target(lldb-framework-headers
+ DEPENDS ${framework_headers}
+ COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh
xiaobai wrote:
> This should not just depend on `
keith updated this revision to Diff 157525.
keith added a comment.
- Make headers a post build command
https://reviews.llvm.org/D49779
Files:
cmake/modules/LLDBFramework.cmake
Index: cmake/modules/LLDBFramework.cmake
===
--- cm
xiaobai requested changes to this revision.
xiaobai added a comment.
This revision now requires changes to proceed.
I think this might actually not do what we want it to do. I've commented inline
with my concerns.
Comment at: cmake/modules/LLDBFramework.cmake:21
add_custom_
keith added inline comments.
Comment at: cmake/modules/LLDBFramework.cmake:21
add_custom_command(TARGET lldb-framework POST_BUILD
COMMAND ${CMAKE_COMMAND} -E copy_directory
${CMAKE_CURRENT_BINARY_DIR}/FrameworkHeaders $/Headers
COMMAND ${CMAKE_COMMAND} -E create_sym
xiaobai added a comment.
If I understand correctly, this is putting the headers directly into the
framework? That's a pretty good idea :D
In https://reviews.llvm.org/D49779#1174659, @keith wrote:
> It seems like if this was a common occurrence, it would've been fixed
> earlier, so I'm wonderin
labath added a reviewer: xiaobai.
labath added a comment.
Adding Alex, as he was doing a lot of framework work lately.
https://reviews.llvm.org/D49779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
keith added a comment.
It seems like if this was a common occurrence, it would've been fixed earlier,
so I'm wondering if there's a difference in the way I'm building lldb that
causes this. Using cmake:
cmake ../llvm -G Ninja -DCMAKE_BUILD_TYPE=Debug
-DCMAKE_EXPORT_COMPILE_COMMANDS=YES -DLLD
keith created this revision.
keith added reviewers: kastiglione, beanz.
Herald added a subscriber: mgorny.
Previously the framework-header-fix script would change the sources
before they were copied, leading to unnecessary rebuilds on repeat
`ninja lldb` invocations. This runs the script on the he
18 matches
Mail list logo
