apolyakov marked an inline comment as done.
apolyakov added inline comments.
Comment at: lit/tools/lldb-mi/target/target-select-so-path.test:4
+# RUN: %cc -o %t %p/inputs/main.c -g
+# RUN: python %p/inputs/target-select-so-path.py "%debugserver" "%lldbmi %t" %s
+
tatyana-krasnukha added inline comments.
Comment at: lit/tools/lldb-mi/target/target-select-so-path.test:4
+# RUN: %cc -o %t %p/inputs/main.c -g
+# RUN: python %p/inputs/target-select-so-path.py "%debugserver" "%lldbmi %t" %s
+
Could you run the same python that
tatyana-krasnukha added a comment.
On CentOS this test hangs forever. If I manually kill lldb-mi and lldb-server
subprocesses, the output is
--
Exit Code: 1
Command Output (stderr):
--
/lldb/lit/tools/lldb-mi/target/target-select-so-path.test:16:10: error:
CHECK: expected string no
teemperor added a comment.
This test is timing out for me on Arch Linux. Any idea why?
bash -x
./tools/lldb/lit/tools/lldb-mi/target/Output/target-select-so-path.test.script
+ set -o pipefail
+ set -x
+ : 'RUN: at line 3'
+ /data/llvm/dbg-build/./bin/clang -o
/data/llvm/dbg-build/tools/lldb/lit
labath added a comment.
In https://reviews.llvm.org/D49739#1194037, @apolyakov wrote:
> I think those options don't fit. I'm looking for behavior like this:
>
> ~/workspace/gsoc/build/bin/lldb-server gdbserver --pipe 1 localhost:0
> 36251
>
>
> Here lldb-server prints out the port number it i
apolyakov added a comment.
I think those options don't fit. I'm looking for behavior like this:
~/workspace/gsoc/build/bin/lldb-server gdbserver --pipe 1 localhost:0
36251
Here lldb-server prints out the port number he is listening on and continues
running.
If debugserver can choose a tcp
jingham added a subscriber: apolyakov.
jingham added a comment.
It looks like lots of options to debugserver were added without also adding
them to the --help output. Probably because there are so few clients they
already know the options (the same person added & used them...) But if you
look
It looks like lots of options to debugserver were added without also adding
them to the --help output. Probably because there are so few clients they
already know the options (the same person added & used them...) But if you
look at the actual options in debugserver.cpp, you will see:
{"u
apolyakov added a subscriber: t.p.northover.
apolyakov added a comment.
It seems that `target-select-so-path.test` hangs on macOS. Thanks to
@t.p.northover for noting this.
The debugserver doesn't have `--pipe` option, so on macOS it fails to start and
the test hangs waiting for output from de
jingham added a comment.
Thanks! No need for review...
Repository:
rL LLVM
https://reviews.llvm.org/D49739
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
apolyakov added a comment.
Sure, will do it.
Repository:
rL LLVM
https://reviews.llvm.org/D49739
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham added a comment.
Could you add a short doc to this API - it's particularly useful to do this to
the .i version. I know there are lots of API's that don't have docs, but that
is not a happy situation. I'd like it if we all at least didn't make the
problem worse by documenting all the n
This revision was automatically updated to reflect the committed changes.
Closed by commit rL339175: Add new API to SBTarget class (authored by
apolyakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49739?vs=159582&id=159587#toc
R
apolyakov updated this revision to Diff 159582.
apolyakov retitled this revision from "[WIP] Re-implement MI target-select
command." to "Add new API to SBTarget class".
apolyakov edited the summary of this revision.
apolyakov added a comment.
Splitted the patch into two parts: this part with the
14 matches
Mail list logo
