teemperor added a comment.
Sorry, I think I know why this is happening. Give me a bit to make a patch.
Repository:
rL LLVM
https://reviews.llvm.org/D49207
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
stella.stamenova added a comment.
I am debugging through it right now, but I believe this change caused several
tests on Windows with Python 3 to fail. The failures are all related to UTF-8.
For example:
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 0:
invalid start by
This revision was not accepted when it landed; it landed in state "Needs
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336955: Get rid of the C-string parameter in DoExecute
(authored by teemperor, committed by ).
Herald added a subscriber
teemperor accepted this revision.
teemperor added a comment.
Davide also approved it offline (thx).
https://reviews.llvm.org/D49207
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jingham added a comment.
Yeah, you are right about that. The command string presented to commands never
contained the command name, that always got stripped off. But I don't think
that ever left the command string to be nullptr... So you are right, that was
just dead code.
https://reviews.
teemperor added a comment.
@jingham I thought the same at first, but giving an error `command.empty()`
turns out to be a problem. The command string contains the arguments (but not
the command name itself). So when calling for example `bt` we would hit this
error (as there are no args, so `com
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
I think the CommandObjectRegex check that you took out wasn't something devious
or clever, but was just an incomplete (and so buggy) version of the check:
if (command && command[0]
teemperor created this revision.
teemperor added a reviewer: davide.
This patch gets rid of the C-string parameter in the
RawCommandObject::DoExecute function,
making the code simpler and less memory unsafe.
There seems to be a assumption in some command objects that this parameter
could be a n
