[Lldb-commits] [PATCH] D49006: Add LLDB_API to SBAddress's operator==

2018-07-07 Thread Alexander Polyakov via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL336494: Add LLDB_API to SBAddress's operator==. (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49006?vs=154360&id=154

[Lldb-commits] [PATCH] D49006: Add LLDB_API to SBAddress's operator==

2018-07-07 Thread Aleksandr Urakov via Phabricator via lldb-commits
aleksandr.urakov added a comment. Thank you! It builds well on Windows with this patch for me. Can you commit this, please? I have no commit access. https://reviews.llvm.org/D49006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://l

[Lldb-commits] [PATCH] D49006: Add LLDB_API to SBAddress's operator==

2018-07-06 Thread Alexander Polyakov via Phabricator via lldb-commits
apolyakov added a comment. Unfortunately, I don't have an opportunity to check this out on windows, but if this works, I'll be glad that someone found out how to fix compilation failure on windows. https://reviews.llvm.org/D49006 ___ lldb-commits

[Lldb-commits] [PATCH] D49006: Add LLDB_API to SBAddress's operator==

2018-07-06 Thread Alexander Polyakov via Phabricator via lldb-commits
apolyakov accepted this revision. apolyakov added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D49006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [PATCH] D49006: Add LLDB_API to SBAddress's operator==

2018-07-06 Thread Aleksandr Urakov via Phabricator via lldb-commits
aleksandr.urakov added a comment. Add LLDB_API to SBAddress's operator== to fix lldb-mi build on Windows. https://reviews.llvm.org/D49006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c