[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL336200: Add new API to SBTarget and SBModule classes. (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48801?vs=153846&

[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

apolyakov updated this revision to Diff 153846. apolyakov added a comment. Updated passing an argument to `find_compile_units` function. https://reviews.llvm.org/D48801 Files: include/lldb/API/SBModule.h include/lldb/API/SBTarget.h packages/Python/lldbsuite/test/python_api/module_section

[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

aprantl added a comment. Fre Comment at: packages/Python/lldbsuite/test/python_api/target/TestTargetAPI.py:54 +self.setTearDownCleanup(dictionary=d) +self.find_compile_units('b.out') + apolyakov wrote: > aprantl wrote: > > shouldn't this be `sel

[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

jingham added a comment. Alex is right, lldb uses @param everywhere. https://reviews.llvm.org/D48801 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

apolyakov added inline comments. Comment at: include/lldb/API/SBModule.h:136 + /// + /// @param[in] sb_file_spec + /// A lldb::SBFileSpec object that contains source file aprantl wrote: > We typically use `\param` instead of `@param` in LLVM. I did it like

[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

apolyakov added inline comments. Comment at: packages/Python/lldbsuite/test/python_api/target/TestTargetAPI.py:54 +self.setTearDownCleanup(dictionary=d) +self.find_compile_units('b.out') + aprantl wrote: > shouldn't this be `self.getBuildArtifact(

[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: include/lldb/API/SBModule.h:136 + /// + /// @param[in] sb_file_spec + /// A lldb::SBFileSpec object that contains source file We typ

[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

apolyakov updated this revision to Diff 153817. apolyakov added a comment. Added documentation and tests. https://reviews.llvm.org/D48801 Files: include/lldb/API/SBModule.h include/lldb/API/SBTarget.h packages/Python/lldbsuite/test/python_api/module_section/TestModuleAndSection.py pack

[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

clayborg added a comment. needs a test, but looks good. https://reviews.llvm.org/D48801 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

aprantl added a comment. This seems like a reasonable addition. Could you also add documentation for the new API? https://reviews.llvm.org/D48801 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

apolyakov created this revision. apolyakov added reviewers: aprantl, clayborg. The new API allows to find a list of compile units related to target/module. https://reviews.llvm.org/D48801 Files: include/lldb/API/SBModule.h include/lldb/API/SBTarget.h scripts/interface/SBModule.i scripts