apolyakov abandoned this revision.
apolyakov added a comment.
Abandoned since suggested functionality is optional.
https://reviews.llvm.org/D48775
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
aprantl added a comment.
Okay then let's not do this for now. It's fine to revisit this later if there
turns out to be a good use-case for it, but every SBAPI call we introduce has
to be supported indefinitely and can therefore be quite expensive to maintain.
https://reviews.llvm.org/D48775
apolyakov added a comment.
It's hard to choose something, both variants are good enough. But, if there is
no necessity in such a method, we can drop it.
https://reviews.llvm.org/D48775
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
aprantl added a comment.
Have you seen my earlier question:
> Is the dummy target something we need to expose over the SBAPI?
> I see that other places in lldb-mi query if (sbTarget ==
> rSessionInfo.GetDebugger().GetDummyTarget()).
> Would that be sufficient?
https://reviews.llvm.org/D4877
apolyakov added a comment.
I think we can remove comments added by me and commit patch as it is. Any
thoughts about it?
https://reviews.llvm.org/D48775
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
aprantl added a comment.
Is the dummy target something we need to expose over the SBAPI?
I see that other places in lldb-mi query `if (sbTarget ==
rSessionInfo.GetDebugger().GetDummyTarget())`. Would that be sufficient?
https://reviews.llvm.org/D48775
___
apolyakov updated this revision to Diff 153516.
apolyakov edited the summary of this revision.
apolyakov added a comment.
Added description to source files and commit message.
https://reviews.llvm.org/D48775
Files:
include/lldb/API/SBTarget.h
scripts/interface/SBTarget.i
source/API/SBTarg
brucem requested changes to this revision.
brucem added inline comments.
This revision now requires changes to proceed.
Comment at: include/lldb/API/SBTarget.h:65
+ bool IsDummy() const;
+
Could you add a doc comment here explaining it?
Comm
apolyakov created this revision.
apolyakov added reviewers: aprantl, clayborg.
The new member function allows to check if a target is dummy or real.
https://reviews.llvm.org/D48775
Files:
include/lldb/API/SBTarget.h
scripts/interface/SBTarget.i
source/API/SBTarget.cpp
Index: source/API/
